Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new NetApp ONTAP Cinder storage backend to Sunbeam and wires it into the unit test suite so the backend is discoverable and validated alongside existing backends.
Changes:
- Add
NetAppBackendandNetAppConfig(including secret-marked config fields) undersunbeam.storage.backends.netapp. - Add NetApp-specific unit tests and include the backend in shared backend tests/fixtures.
- Extend common backend uniqueness/expectation tests to include
netapp.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
sunbeam-python/tests/unit/sunbeam/storage/backends/test_netapp.py |
New unit tests covering NetApp backend basics and config validation/secret markers. |
sunbeam-python/tests/unit/sunbeam/storage/backends/test_common.py |
Adds NetApp to shared “unique type/charm name” and expected-values tests. |
sunbeam-python/tests/unit/sunbeam/storage/backends/conftest.py |
Adds a netapp_backend fixture and includes NetApp in the parametrized any_backend fixture. |
sunbeam-python/sunbeam/storage/backends/netapp/backend.py |
Implements NetAppBackend and a large NetAppConfig model for charm configuration. |
sunbeam-python/sunbeam/storage/backends/netapp/__init__.py |
New package initializer for the NetApp backend module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ahmad-can
force-pushed
the
feature/generate-netapp-charm
branch
from
148c7da to
20050f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Charm https://review.opendev.org/c/openstack/sunbeam-charms/+/984497